New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows instructions update + citation update #1361
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1361 +/- ##
==========================================
+ Coverage 87.03% 87.03% +<.01%
==========================================
Files 228 228
Lines 29057 29058 +1
Branches 3128 3128
==========================================
+ Hits 25290 25292 +2
Misses 3059 3059
+ Partials 708 707 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Just a couple of suggestions/questions.
[11] Rokem A, Yeatman JD, Pestilli F, Kay KN, Mezer A, et al. (2015), `Evaluating the Accuracy of Diffusion MRI Models in White Matter. <http://journals.plos.org/plosone/article?id=10.1371/journal.pone.0123272>` | ||
|
||
[12] Ocegueda O, Dalmau O, Garyfallidis E, Descoteaux M, Rivera M, `On the computation of integrals over fixed-size rectangles of arbitrary dimension. <http://www.sciencedirect.com/science/article/pii/S0167865516300861>` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add: [Re] Optimization of a free water elimination two-compartment model for diffusion tensor imaging, Rafael Neto Henriques, Ariel Rokem, Eleftherios Garyfallidis, Samuel St-Jean, Eric Thomas Peterson, Marta Morgado Correia, ReScience volume 3, issue 1, article number 2, 2017.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done ! -> e55e20a
ISSUE_TEMPLATE.md
Outdated
- [ ] Operating system and version (run `python -c "import platform; print(platform.platform())"`) | ||
- [ ] Python version (run `python -c "import sys; print("Python", sys.version)"`) | ||
- [ ] dipy version (run `python -c "import dipy; print(dipy.__version__)"`) | ||
- [ ] dependency version (numpy, scipy, vtk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to know versions of other dependencies or just these three?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose they are the most important, but I add the others dependencies to get the complete information (last commit)
doc/installation.rst
Outdated
|
||
conda install gcc | ||
|
||
After this installation, gcc will be your default compiler in anaconda environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anaconda
Okay, looks ready. Release day. Merging... |
Looks, good. Release day! Merging! |
Windows instructions update + citation update
The PR is just an update of windows instructions.
This should resolve #1248, #1084, #1146.
I use this opportunity to add an issue template